Skip to content

Fix rad degrees #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Fix rad degrees #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d619dbf
FIX: yaml files: degrees to rad
jklymak Aug 31, 2024
8cee59c
TST: fix the tests
jklymak Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/_copyresultstoexpected.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
"""
If we run the tests and decide we want all the test results to be copied over, this is faster...
"""
from pathlib import Path
from shutil import copy

todo = {'example-data/example-seaexplorer/L0-timeseries-test/dfo-eva035-20190718.nc':
'expected/example-seaexplorer/L0-timeseries',
'example-data/example-seaexplorer-raw/L0-timeseries-test/dfo-bb046-20200908.nc': 'expected/example-seaexplorer-raw/L0-timeseries',
'example-data/example-slocum/L0-timeseries/dfo-rosie713-20190615.nc': 'expected/example-slocum/L0-timeseries',
'example-data/example-slocum-littleendian/L0-timeseries-test/dfo-maria997-20220614.nc': 'expected/example-slocum-littleendian/L0-timeseries'

}

for td in todo:
copy(td, todo[td])

8 changes: 4 additions & 4 deletions tests/example-data/example-seaexplorer-raw/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,21 +128,21 @@ netcdf_variables:
source: Heading
long_name: glider heading angle
standard_name: platform_orientation
units: rad
units: degrees
coordinates: time depth latitude longitude

pitch:
source: Pitch
long_name: glider pitch angle
standard_name: platform_pitch_angle
units: rad
units: degrees
coordinates: time depth latitude longitude

roll:
source: Roll
long_name: glider roll angle
standard_name: platform_roll_angle
units: rad
units: degrees
coordinates: time depth latitude longitude

# data parameters
Expand Down Expand Up @@ -329,7 +329,7 @@ profile_variables:
instrument_ctd:
comment: pumped CTD
calibration_date: "2018-11-02"
calibration_report:
calibration_report:
factory_calibrated: "yes"
long_name: Seabird Glider Payload CTD
make_model: Seabird GPCTD
Expand Down
6 changes: 3 additions & 3 deletions tests/example-data/example-seaexplorer/deploymentRealtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,21 +124,21 @@ netcdf_variables:
source: Heading
long_name: glider heading angle
standard_name: platform_orientation
units: rad
units: degrees
coordinates: time depth latitude longitude

pitch:
source: Pitch
long_name: glider pitch angle
standard_name: platform_pitch_angle
units: rad
units: degrees
coordinates: time depth latitude longitude

roll:
source: Roll
long_name: glider roll angle
standard_name: platform_roll_angle
units: rad
units: degrees
coordinates: time depth latitude longitude

# data parameters
Expand Down
6 changes: 3 additions & 3 deletions tests/example-data/example-slocum-littleendian/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,21 +128,21 @@ netcdf_variables:
source: m_heading
long_name: glider heading angle
standard_name: platform_orientation
units: rad
units: degrees
coordinates: time depth latitude longitude

pitch:
source: m_pitch
long_name: glider pitch angle
standard_name: platform_pitch_angle
units: rad
units: degrees
coordinates: time depth latitude longitude

roll:
source: m_roll
long_name: glider roll angle
standard_name: platform_roll_angle
units: rad
units: degrees
coordinates: time depth latitude longitude

# profile info:
Expand Down
6 changes: 3 additions & 3 deletions tests/example-data/example-slocum/deploymentRealtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,19 +121,19 @@ netcdf_variables:
source: m_heading
long_name: glider heading angle
standard_name: platform_orientation
units: rad
units: degrees

pitch:
source: m_pitch
long_name: glider pitch angle
standard_name: platform_pitch_angle
units: rad
units: degrees

roll:
source: m_roll
long_name: glider roll angle
standard_name: platform_roll_angle
units: rad
units: degrees

# profile info:
waypoint_latitude:
Expand Down
Binary file modified tests/expected/example-seaexplorer-raw/L0-timeseries/dfo-bb046-20200908.nc
View file
Open in desktop
Binary file not shown.
Binary file modified tests/expected/example-seaexplorer/L0-timeseries/dfo-eva035-20190718.nc
View file
Open in desktop
Binary file not shown.
Binary file modified tests/expected/example-slocum-littleendian/L0-timeseries/dfo-maria997-20220614.nc
View file
Open in desktop
Binary file not shown.
Binary file modified tests/expected/example-slocum/L0-timeseries/dfo-rosie713-20190615.nc
View file
Open in desktop
Binary file not shown.