Fix time variable attributes for IOOS metadata #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the errors in the tests are from hard-coded tests that you will just need to change in the test files. |
Updating the slocum processing, correcting paths for the seaexplorer processing, and updating the test data for all processing. Added a new updated yaml file.
|
@jklymak, am I clear to merge? |
|
@hvdosser and I noted that this didn't merge cleanly somehow. Given that the substantive changes are modest, let's revert and make a brand new PR where we are more careful about the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the attributes for the time variable in ncprocess.py to be compliant with IOOS requirements, including the calendar, units, and FillValue used.