[LibWebsocketServer] Clang - Fix memory management for URI in eventCallback #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-jimenez
requested changes
Jun 12, 2025
thomas-brunel
force-pushed
the
fix/VLA_unsupported_C++
branch
from
1d1bc44 to
da4cc63
Compare
…llback Signed-off-by: Thomas BRUNEL <thomas.brunel2@icloud.com>
thomas-brunel
force-pushed
the
fix/VLA_unsupported_C++
branch
from
da4cc63 to
e42a42a
Compare
|
@c-jimenez Thank you for the feedback. I've made the changes. |
c-jimenez
requested changes
Jun 13, 2025
Co-authored-by: c-jimenez <18682655+c-jimenez@users.noreply.github.com>
c-jimenez
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the PR, to solve one the error mentioned in my issue #250.
From what I found, dynamic allocation of arrays is not standard in C++, and Clang reports it as an error, preventing compilation.