Update three-model.js #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was necessary to make sure each material has "skinning" set to true. I also added the ability to morphTargets to true for some future Morph animations on SkinnedMeshes (needs some thought there, so I didn't add any additional code, but the above materials will allow custom scripts to later be added by someone using this library to create and play morph animations until we have a proper solution).... This will solve c-frame#87, as well as c-frame#86
|
Thanks, could you check #90? I am hoping i've got the critical parts of this PR included there. |
|
Not sure if I wrote this somewhere else, but yes, I have tried your #90 PR, I copied the specific code locally and it works on all 4 JSON models. 👍 |
|
Great, I did see the other comment although I'm not sure where it went either haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was necessary to make sure each material has "skinning" set to true. I also added the ability to morphTargets to true for some future Morph animations on SkinnedMeshes (needs some thought there, so I didn't add any additional code, but the above materials will allow custom scripts to later be added by someone using this library to create and play morph animations until we have a proper solution)....
This will solve #87, as well as #86
I have tested the pull request on the "knight.json" mention in 87/86