CCMap: implement {of,add}_*_with family of function with update #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspiwack
force-pushed
the
ccmap/of-iter-with-update
branch
from
d5e53fd to
17f9fae
Compare
This is comparable in conciseness and clarity as an explicit try/with but it paves the way for a more efficient implementation using the `update` from the Stdlib which, I presume, uses a one-pass algorithm.
aspiwack
force-pushed
the
ccmap/of-iter-with-update
branch
from
17f9fae to
2084066
Compare
|
merci bien 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is comparable in conciseness and clarity as an explicit try/with
but it paves the way for a more efficient implementation using the
updatefrom the Stdlib which, I presume, uses a one-pass algorithm.I didn't do the same for
Hashtblbecause it isn't clear that there is abeneficial such implementation for hash tables.