Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SuggestUniform to SuggestFloat. #96

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Rename SuggestUniform to SuggestFloat. #96

merged 3 commits into from
Apr 10, 2020

Conversation

c-bata
Copy link
Owner

@c-bata c-bata commented Mar 31, 2020 •
edited
Loading

Like optuna/optuna#1021, I'm considering to rename the suggest APIs.

@c-bata
Copy link
Owner Author

c-bata commented Mar 31, 2020 •
edited
Loading

I actually still wondering that this API is more friendly, or not.
I guess SuggestFloat is friendly for users who has never used any hyperparameter tuning library. But SuggestUniform is more friendly for people who has already used hyperopt or other hyperparameter tuning library.

@c-bata c-bata mentioned this pull request Apr 9, 2020
Merged
@c-bata
Copy link
Owner Author

c-bata commented Apr 10, 2020

I decided to merge this pull request to follow the optuna's design.

@c-bata c-bata merged commit ab8d4ca into master Apr 10, 2020
@c-bata c-bata deleted the suggest-float branch April 10, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c-bata