Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git tags for version source and allow no tags #10

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Use git tags for version source and allow no tags #10

merged 1 commit into from
Jun 5, 2020

Conversation

elestedt
Copy link
Contributor

@elestedt elestedt commented Jun 2, 2020

This will allow this tool to use only information in the repository and still generate a log.

@elestedt elestedt force-pushed the feature/fromGitTags branch 2 times, most recently from 1037685 to 2bcc3c5 Compare June 3, 2020 15:02
@elestedt
Copy link
Contributor Author

elestedt commented Jun 3, 2020

I tried to write the tests, but I couldn't get a working mock if IRepository.

bzumhagen
bzumhagen requested changes Jun 4, 2020
View reviewed changes
Copy link
Owner

@bzumhagen bzumhagen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make the suggested changes, I think you should be able to easily write some tests.

Also, minor version should be incremented.

@elestedt elestedt force-pushed the feature/fromGitTags branch from 2bcc3c5 to 86a2432 Compare June 4, 2020 15:19
@elestedt
Copy link
Contributor Author

elestedt commented Jun 4, 2020 •
edited
Loading

If you make the suggested changes, I think you should be able to easily write some tests.

Also, minor version should be incremented.

Updating minor version. Maybe you should look into GitVersion to do that automatically from a tag in the repo? That's what I usually do. If you'd like I can make a PR for that as well.

@elestedt elestedt force-pushed the feature/fromGitTags branch from 86a2432 to ea5942c Compare June 4, 2020 15:22
@elestedt elestedt requested a review from bzumhagen June 4, 2020 15:23
@elestedt elestedt force-pushed the feature/fromGitTags branch 2 times, most recently from e2fd741 to f37c076 Compare June 4, 2020 15:25
@elestedt
Copy link
Contributor Author

elestedt commented Jun 4, 2020

Doing it this new way means there's a lot less code to maintain :)

@elestedt
Copy link
Contributor Author

elestedt commented Jun 4, 2020

Hmm, I need to check some things - it's not showing a proper changelog :/ I'll let you know in comment when it's working again.

@elestedt elestedt force-pushed the feature/fromGitTags branch from f37c076 to 8c040e5 Compare June 4, 2020 15:35
@elestedt
Copy link
Contributor Author

elestedt commented Jun 4, 2020

There. Verified working on a local repo.

@elestedt elestedt force-pushed the feature/fromGitTags branch 2 times, most recently from 34a8aad to a0c0a66 Compare June 4, 2020 16:28
bzumhagen
bzumhagen requested changes Jun 4, 2020
View reviewed changes
@elestedt elestedt force-pushed the feature/fromGitTags branch 2 times, most recently from e207a25 to f331670 Compare June 4, 2020 18:53
@elestedt
Copy link
Contributor Author

elestedt commented Jun 4, 2020

Only a few commits show up in the log right now. I'll get it right and then signal for review once I think I've fixed everything.

@elestedt elestedt force-pushed the feature/fromGitTags branch from f331670 to 1bbf5c0 Compare June 4, 2020 19:57
@elestedt
Copy link
Contributor Author

elestedt commented Jun 4, 2020

Hope I got everything now

@elestedt elestedt requested a review from bzumhagen June 4, 2020 20:06
@elestedt elestedt force-pushed the feature/fromGitTags branch 3 times, most recently from 02737e6 to de5b40b Compare June 4, 2020 21:30
bzumhagen
bzumhagen requested changes Jun 5, 2020
View reviewed changes
@elestedt elestedt force-pushed the feature/fromGitTags branch 2 times, most recently from 4599a6b to ba14aaa Compare June 5, 2020 15:22
@elestedt elestedt requested a review from bzumhagen June 5, 2020 18:25
bzumhagen
bzumhagen requested changes Jun 5, 2020
View reviewed changes
Copy link
Owner

@bzumhagen bzumhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to commit message

tag: Added
version: 0.9.0

@elestedt elestedt force-pushed the feature/fromGitTags branch from ba14aaa to 35f9212 Compare June 5, 2020 20:50
@elestedt elestedt requested a review from bzumhagen June 5, 2020 20:50
@bzumhagen bzumhagen merged commit 051b95b into bzumhagen:master Jun 5, 2020
@elestedt elestedt deleted the feature/fromGitTags branch June 6, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzumhagen bzumhagen bzumhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elestedt @bzumhagen