Skip to content

Allow loadbalancer timeout to be configureable #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Allow loadbalancer timeout to be configureable #49

merged 3 commits into from
Dec 15, 2023

Conversation

jvisker
Copy link
Contributor

@jvisker jvisker commented Dec 15, 2023

No description provided.

Copy link

github-actions bot commented Dec 15, 2023

Terraform Plan:

will create 26 resources:

  • aws_efs_file_system - my_efs
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_listener - test_listener
  • aws_alb_target_group - blue
  • aws_alb_target_group - green
  • aws_cloudwatch_log_group - container_log_group
  • aws_cloudwatch_log_group - xray_log_group
  • aws_codedeploy_app - app
  • aws_codedeploy_deployment_group - deploymentgroup
  • aws_ecs_cluster - new_cluster
  • aws_ecs_service - service
  • aws_ecs_task_definition - task_def
  • aws_iam_policy - secrets_access
  • aws_iam_role - task_execution_role
  • aws_iam_role - task_role
  • aws_iam_role_policy_attachment - secret_task_policy_attach
  • aws_iam_role_policy_attachment - secrets_policy_attach
  • aws_iam_role_policy_attachment - task_execution_policy_attach
  • aws_iam_role_policy_attachment - xray_task_policy_attach
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - fargate_service_sg
  • local_file - appspec_json

see details

Copy link
Member

@GaryGSC GaryGSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suddenly annoyed that we're inconsistent with our prefixes. Most variables here use alb_, but then we also have some for lb_logging_.

Anyway, two nits:

  • I'd call this a minor version update
  • lb_ -> alb_

@jvisker
Copy link
Contributor Author

jvisker commented Dec 15, 2023

@GaryGSC I switched that. I didn't even notice we had two different prefixes going on.

@jvisker jvisker merged commit 9c72225 into main Dec 15, 2023
@jvisker jvisker deleted the timeout branch December 15, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants