Skip to content

Feat: update module to handle existing ECS cluster #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 4, 2023
Merged

Feat: update module to handle existing ECS cluster #44

merged 11 commits into from
Oct 4, 2023

Conversation

chlohilt
Copy link
Contributor

@chlohilt chlohilt commented Oct 2, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Terraform Plan:

will create 26 resources:

  • aws_efs_file_system - my_efs
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_listener - test_listener
  • aws_alb_target_group - blue
  • aws_alb_target_group - green
  • aws_cloudwatch_log_group - container_log_group
  • aws_cloudwatch_log_group - xray_log_group
  • aws_codedeploy_app - app
  • aws_codedeploy_deployment_group - deploymentgroup
  • aws_ecs_cluster - new_cluster
  • aws_ecs_service - service
  • aws_ecs_task_definition - task_def
  • aws_iam_policy - secrets_access
  • aws_iam_role - task_execution_role
  • aws_iam_role - task_role
  • aws_iam_role_policy_attachment - secret_task_policy_attach
  • aws_iam_role_policy_attachment - secrets_policy_attach
  • aws_iam_role_policy_attachment - task_execution_policy_attach
  • aws_iam_role_policy_attachment - xray_task_policy_attach
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - fargate_service_sg
  • local_file - appspec_json

see details

@chlohilt chlohilt marked this pull request as ready for review October 2, 2023 19:15
yoshutch
yoshutch requested changes Oct 2, 2023
View reviewed changes
yoshutch
yoshutch reviewed Oct 4, 2023
View reviewed changes
@chlohilt @yoshutch
Update outputs.tf
f7985d0 
Co-authored-by: Scott Hutchings <yoshutch@gmail.com>
yoshutch
yoshutch reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@yoshutch yoshutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Now we just need to update the README and examples to have a new major version (v6.0.0 I think)

@chlohilt chlohilt requested a review from yoshutch October 4, 2023 18:12
@chlohilt chlohilt changed the title Chore: update module to handle existing ECS cluster Feat: update module to handle existing ECS cluster Oct 4, 2023
@chlohilt chlohilt merged commit 6a8b5fc into main Oct 4, 2023
@chlohilt chlohilt deleted the existingCluster branch October 4, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshutch yoshutch yoshutch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlohilt @yoshutch