Repository navigation
TCP sockets for connections #4
Description
Activity
Okay, i'll get started on it.
Could you specify why exactly are we using
fromUnixSocket()andfromInetSocket()function?Instead,
SpecifyInetSocketConnection()andUnixSocketConnection()indefault()function by comparing the socketPath being unix_sock_path or named pipes (windows).Example snippet:
public static default(socketPath: string): JunoModule { if (['\\\\?\\pipe', '\\\\.\\pipe'].some(p => socketPath.includes(p))) { return new JunoModule(new InetSocketConnection(socketPath), new JsonProtocol()); } else { return new JunoModule(new UnixSocketConnection(socketPath), new JsonProtocol()); } }
Could the above snippet work?
Could you specify why exactly are we using
fromUnixSocket()andfromInetSocket()function?Those functions will allow you to explicitly set the connection type instead of depending on the default function to categorize it.
Additionally, named pipes aren't supported by Juno....yet. I have no plans to support it as of now, since the throughput of named pipes are not the best. So, the default function should check if the string being passed is a unix socket (a file name) or a bind address. Based on that, it should call the
fromUnixSocketor thefromInetSocketfunction.However, when the
fromUnixSocketfunction is called from a windows system, it should error out.Also, do I extract IP address from the string being passed if it has a valid domain name?
There can't possibly be a domain name. That's an illegal string. The IP address that's mentioned there is the bind address (
127.0.0.1or0.0.0.0or any other bind address). Domain names aren't valid thereReacted by Saurav M H- added 2 commits that reference this issue
on Apr 28, 2020 - added a commit that references this issue
on May 7, 2020
Unix sockets will not work on windows. They only work on macOS and Linux.
Juno, however, supports standard inet sockets for communication. That needs to be incorporated into this library.
The following things are needed:
JunoModule.tsshould provide static functions calledfromUnixSocket(path: string)andfromInetSocket(host: string, port: number).default(string)function should be modified to check if the string is a unix socket path or an inet socket and accordingly call the corresponding function.fromUnixSocketfunction should throw an error and crash the program when called on windows, with an appropriate error message.src/connection/inet-socket-connection.tsfile that implements the connection for inet sockets. You can take inspiration from unix socket to understand how it works.Ping here if you need any help