fix: remove unreachable absolute path check in CLI run command#405
Open
hobostay wants to merge 1 commit intobytedance:mainfrom
Open
fix: remove unreachable absolute path check in CLI run command#405hobostay wants to merge 1 commit intobytedance:mainfrom
hobostay wants to merge 1 commit intobytedance:mainfrom
Conversation
The check `if not Path(working_dir).is_absolute()` on line 346 is dead code because both branches above guarantee an absolute path: - Line 336: `working_dir = os.path.abspath(working_dir)` always returns an absolute path - Line 342: `working_dir = os.getcwd()` always returns an absolute path The error message on line 348 could never be displayed. Remove the unreachable block. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.py:345-350that checks ifworking_diris an absolute path but can never be reachedProblem
In the
run()command, the block:is unreachable because both code branches above guarantee an absolute path:
working_diris provided:os.path.abspath(working_dir)on line 336 always returns an absolute pathworking_diris not provided:os.getcwd()on line 342 always returns an absolute pathThis error message could never actually be displayed to the user.
Fix
Removed the unreachable block.
Test plan
trae run "task" --working-dir ./relativestill works (abspath handles it)trae run "task"without working-dir still works (uses cwd)🤖 Generated with Claude Code