fix: replace unsafe os.system calls with Python stdlib in build script#404
Open
hobostay wants to merge 1 commit intobytedance:mainfrom
Open
fix: replace unsafe os.system calls with Python stdlib in build script#404hobostay wants to merge 1 commit intobytedance:mainfrom
hobostay wants to merge 1 commit intobytedance:mainfrom
Conversation
Replace os.system("rm -rf ...") and os.system("cp ...") with safer
shutil and os module equivalents. This improves:
- Security: avoids shell injection vectors
- Cross-platform: works on Windows where rm/cp are unavailable
- Error handling: Python APIs raise proper exceptions on failure
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.system("rm -rf ...")andos.system("cp ...")calls inbuild_with_pyinstaller()with safer Python stdlib equivalents (shutil,os)Problem
The
build_with_pyinstaller()function usesos.system()to run shell commands likerm -rf,cp, andmkdir. This is problematic because:os.system()spawns a shell, introducing potential injection vectorsrmandcpare Unix-only commands; they don't exist on Windowsos.system()only returns an exit code — no proper exceptions on failureFix
Replaced all
os.system()calls with:shutil.rmtree()instead ofrm -rfshutil.copy()instead ofcpshutil.copytree()instead ofcp -ros.makedirs()instead ofmkdirTest plan
build_with_pyinstaller()and verify the build output is identical🤖 Generated with Claude Code