Repository navigation
Conversation
Go 1.27 has reached GA, so switch all CI workflows from '1.27.0-rc.2' to '1.27.x' to validate against the released version.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92dc9b01ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| strategy: | ||
| matrix: | ||
| go-version: [1.18.x, 1.21.x, 1.25.x, '1.27.0-rc.2'] | ||
| go-version: [1.18.x, 1.21.x, 1.25.x, 1.27.x] |
There was a problem hiding this comment.
When this matrix begins testing the final Go 1.27 release, the manual reproduction commands still force GOTOOLCHAIN=go1.27rc2 in compatibility/README.md:27-35 and docs/sonic-go127-compatibility.md:492-526. Developers following those guides will therefore validate RC2 rather than the release exercised by CI, potentially producing misleading compatibility results when compiler, runtime, or jsonv2 behavior differs between RC2 and GA. Update those commands and the now-completed final-acceptance text alongside the matrix.
AGENTS.md reference: AGENTS.md:L27-L29
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 51.86% 53.36% +1.49%
==========================================
Files 127 171 +44
Lines 10893 14146 +3253
==========================================
+ Hits 5650 7549 +1899
- Misses 4920 6502 +1582
+ Partials 323 95 -228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates Sonic’s GitHub Actions CI matrices to test against the Go 1.27 GA release line (latest patch in the 1.27 series) rather than a specific release candidate, keeping CI aligned with the supported toolchain.
Changes:
- Replaced
1.27.0-rc.2with1.27.xin the x86 workflow’s setup step and version matrix. - Replaced
1.27.0-rc.2with1.27.xin ARM64, compatibility (Linux/macOS/ARM), and Windows compatibility matrices.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-x86.yml | Switches the pinned Go 1.27 setup and the build matrix entry to 1.27.x. |
| .github/workflows/test-arm64.yml | Updates the ARM64/macOS matrix to test 1.27.x instead of the RC. |
| .github/workflows/compatibility_test.yml | Updates the compatibility test matrix to use 1.27.x. |
| .github/workflows/compatibility_test-windows.yml | Updates the Windows compatibility matrix to use 1.27.x. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Go 1.27 has reached GA, so switch all CI workflows from '1.27.0-rc.2' to '1.27.x' to validate against the released version.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: