vircgroupv2devices: free BPF map when replacing with new one

This leaks the FD of BPF map which means it will not be freed. Signed-off-by: Pavel Hrdina <phrdina@redhat.com> Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
bytedance · Jan 13, 2020 · 7d60846 · 7d60846
1 parent c2642c4
commit 7d60846
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/util/vircgroupv2devices.c b/src/util/vircgroupv2devices.c
@@ -311,6 +311,11 @@ virCgroupV2DevicesAttachProg(virCgroupPtr group,
         VIR_FORCE_CLOSE(group->unified.devices.progfd);
     }
 
+    if (group->unified.devices.mapfd > 0) {
+        VIR_DEBUG("Closing existing map that was replaced by new one.");
+        VIR_FORCE_CLOSE(group->unified.devices.mapfd);
+    }
+
     group->unified.devices.progfd = progfd;
     group->unified.devices.mapfd = mapfd;
     group->unified.devices.max = max;