add http2 for insecure port #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python grpc client does not support "InsecureSkipVerify" option according to grpc/grpc#10701. When we are trying to connect to ingress using grpc "insecure_channel", we will end up in connection issue like 'Trying to connect an http1.x server'.
What this PR does / why we need it:
This PR add an optional annotation for ingress, and if it is set to true, controller will render an extra 'http2' after 'listen 80' directive in nginx config.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: