hotspot: Enable j.l.String related intrinsics #101
+108
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanyangjing
force-pushed
the
cvm8+25/fix-str-intrinsics
branch
from
2954e86 to
08f0243
Compare
luchsh
approved these changes
Nov 17, 2025
luchsh
requested changes
Nov 17, 2025
Collaborator
luchsh
left a comment
luchsh
left a comment
There was a problem hiding this comment.
There seems to be regression in G1, GenZ mode, can we confirmed that? may have to fix it in this patch.
luchsh
reviewed
Nov 24, 2025
| case vmIntrinsics::_arraySort: return inline_array_sort(); | ||
| case vmIntrinsics::_arrayPartition: return inline_array_partition(); | ||
|
|
||
| case vmIntrinsics::_compareToL: return inline_string_compareTo(StrIntrinsicNode::LL); |
Collaborator
There was a problem hiding this comment.
line 291-294 look like jdk25-only
equals: ([C[C)Z compareTo: ([B[B)I getChars: ([CII[CI)V indexOf: ([C[C)I indexOf: ([CI[CII)I indexOfChar: ([CIII)I
duanyangjing
force-pushed
the
cvm8+25/fix-str-intrinsics
branch
from
08f0243 to
bddcc82
Compare
Collaborator
Author
I've updated the average score after a series of test runs. The difference are within 1.5% range so I think it's reasonable fluctuation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equals: ([C[C)Z
compareTo: ([B[B)I
getChars: ([CII[CI)V
indexOf: ([C[C)I
indexOf: ([CI[CII)I
indexOfChar: ([CIII)I