Fix typed array canonical list lowering in JS bindgen #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I was messing around with the JS output and noticed an issue with the way memory is copied when lowering lists of bytes. The argument is a typed array, but it copies the entire underlying buffer, which in some cases can be larger than the view of the typed array. This results in an error since we end up trying to write more data than what's expected.
I fixed this by explicitly providing the byte offset and size.
Let me know if there's any other information I can provide or anything I can do to help get this merged.
Cheers!