Improve handling of strings for backtraces #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
less-strings
branch
from
7af0204 to
7f5340a
Compare
Largely avoid storing strings at all in the `wasmtime-*` internal crates, and instead only store strings in a separate global cache specific to the `wasmtime` crate itself. This global cache is inserted and removed from dynamically as modules are created and deallocated, and the global cache is consulted whenever a `Trap` is created to symbolicate any wasm frames. This also avoids the need to thread `module_name` through the jit crates and back, and additionally removes the need for `ModuleSyncString`.
alexcrichton
force-pushed
the
less-strings
branch
from
bdf1948 to
c591718
Compare
|
ping @yurydelendik, mind taking a look at this? |
yurydelendik
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely avoid storing strings at all in the
wasmtime-*internalcrates, and instead only store strings in a separate global cache
specific to the
wasmtimecrate itself. This global cache is insertedand removed from dynamically as modules are created and deallocated, and
the global cache is consulted whenever a
Trapis created tosymbolicate any wasm frames.
This also avoids the need to thread
module_namethrough the jit cratesand back, and additionally removes the need for
ModuleSyncString.