Skip to content

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Feb 28, 2024

Follow up to #8005 and #7999

@fitzgen fitzgen requested a review from a team as a code owner February 28, 2024 14:06
@fitzgen fitzgen requested review from cfallin and removed request for a team February 28, 2024 14:06
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin cfallin added this pull request to the merge queue Feb 28, 2024
Merged via the queue into bytecodealliance:main with commit 9aa5718 Feb 28, 2024
@fitzgen fitzgen deleted the issue-7999-test-case branch February 28, 2024 16:03
v2 = imul_imm v1, 256
v3 = ireduce.i8 v2
return v3
; return v10 ; v10 = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the precise-output flag set you have to add explicit filecheck match statement like ; check: return v10 ; v10 = 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, didn't realize I was missing a check: here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants