Cranelift: Add .wat to assembly test support and generate Wasm load/store tests for all ISAs
#5439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And generate tests that exercise both Wasm-to-CLIF lowering and Wasm all the way to assembly.
jameysharp
approved these changes
Dec 14, 2022
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
On top of the benefits when the other PR is rebased, this is much easier to review by itself. Thanks! I like it. A couple possible changes below but I wouldn't block merging on them.
cranelift/filetests/filetests/wasm/load-store/make-load-store-tests.sh
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the
.wat-to-assembly support from #5386 as well as the generated tests. By landing this first, and rebasing that on top of this, we can check for regressions and perturbations caused by moving where heap legalization is done in that PR.@cfallin or @jameysharp want to take a look? Nothing has changed from that original PR other than minor rebase related things.