Prepare a 2.0.1 release of Wasmtime #5136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the `push-tag.yml` workflow to work with the new `Cargo.toml` manifest since workspace inheritance was added. This additionally fixes some warnings coming up on CI about our usage of deprecated features on github actions.
* Upgrade our github actions to "node16" Each github actions run has a lot of warnings about using node12 so this upgrades our repository to using node16. I'm hoping no other changes are needed and I suspect other actions we're using are on node12 and will need further updates, but this should help pin down what's remaining. * Update `actions/checkout` workflow to `v3` * Update to `actions/cache@v3` * Update to `actions/upload-artifact@v3` * Drop usage of `actions-rs/toolchain` * Update to `actions/setup-python@v4` * Update mdbook version
…#5091) A local github action we have has been broken for about a month now meaning that the `dev` tag isn't getting updated or getting new releases. This appears to be due to the publication of new versions of these dependencies which are running into issues using one another. I think I've figured out versions that work and have added a `package-lock.json` to ensure we keep using the same versions.
Looks like bytecodealliance#5091 wasn't enough and some of the APIs needed updating with changes made in the meantime. I've updated the action here and additionally made a separate change where the release isn't continually created and deleted but instead left alone and only the tag is updated. This should work for the `dev` release and avoids deleting/recreating on each PR, sending out notifications for new releases.
This is necessary for the `wasmtime-runtime` crate to compile on Windows.
jameysharp
approved these changes
Oct 26, 2022
Contributor
|
What do you think of backporting #5101 as well? It fixes a regression in how long Cranelift takes to build. |
Using rayon adds a lot of dependencies to Cranelift. The total unparallelized time the code that uses rayon takes is less than half a second and it runs at compile time, so there is pretty much no benefit to parallelizing it.
Member
Author
|
Sounds reasonable to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports a number of CI fixes related to the automatic production of artifacts and additionally notably backports #5134 for the true "meat" of the 2.0.1 release. I've slated this for publication tomorrow and will cycle CI to do the bump after this lands for merging of the bump tomorrow to give CI a chance to settle.