Skip to content

Add QEMU CI runner for the s390x architecture #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2021
Merged

Add QEMU CI runner for the s390x architecture #3372

merged 1 commit into from
Sep 20, 2021

Conversation

@uweigand
Copy link
Member

@uweigand uweigand commented Sep 20, 2021

No description provided.

@uweigand
Add QEMU CI runner for the s390x architecture
7c5acfa 
* Add QEMU CI runner for s390x

* Disable lightbeam tests for s390x
@uweigand uweigand mentioned this pull request Sep 20, 2021
Merged
cfallin
cfallin approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks, this is really exciting!

A next step might be to include a builder to build binary packages as well (which would provide tarballs for download on releases, etc.); if you think that's worthwhile, I'm happy to review a followup PR.

@cfallin cfallin merged commit f958c01 into bytecodealliance:main Sep 20, 2021
@uweigand uweigand deleted the s390x-ci branch September 20, 2021 16:26
@uweigand
Copy link
Member Author

uweigand commented Sep 20, 2021

A next step might be to include a builder to build binary packages as well (which would provide tarballs for download on releases, etc.); if you think that's worthwhile, I'm happy to review a followup PR.

Sure, that sounds good. Is this just about adding to the matrix in the "build" workflow target, or are there other changes needed? Not sure if I can actually test this ahead of time ...

@cfallin
Copy link
Member

cfallin commented Sep 20, 2021

I think, so, yeah, basically we just want to copy what's already there for aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfallin cfallin cfallin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uweigand @cfallin