Repository navigation
Re-enqueue low priority items instead of dropping them - #14586
Open
alexcrichton wants to merge 1 commit into
Open
alexcrichton wants to merge 1 commit into
alexcrichton wants to merge 1 commit into
Conversation
When a `run_concurrent` future is dropped we'll properly clean up all resources associated with it, however Wasmtime will end up losing work if the store is resumed later and wasn't otherwise executing any wasm. This replaces the preexisting `Drop`-guard with one that re-enqueues the low-priority work into the store upon cancellation.
github-actions
Bot
added
the
wasmtime:api
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
run_concurrentfuture is dropped we'll properly clean up all resources associated with it, however Wasmtime will end up losing work if the store is resumed later and wasn't otherwise executing any wasm. This replaces the preexistingDrop-guard with one that re-enqueues the low-priority work into the store upon cancellation.