wasmtime: impl ExportLookup for wit_parser::ItemName#13505
Merged
alexcrichton merged 3 commits intoMay 29, 2026
Conversation
* upgrade to wasm-tools family 251, wherein wit-parser has ItemName and wasm-wave can parse to it * wasmtime gets a new feature `wit-parser` to take the optional dep on wit-parser. (This is already in the transitive dep tree with component-model bindgen anyway.) Like with wave, provide a re-export of the crate for convenience under wasmtime::component::wit_parser. * impl ExportLookup for wit_parser::ItemName
alexcrichton
approved these changes
May 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 28, 2026
yagehu
pushed a commit
to yagehu/wasmtime-x
that referenced
this pull request
Jun 1, 2026
…e#13505) * wasmtime: impl ExportLookup for wit_parser::ItemName * upgrade to wasm-tools family 251, wherein wit-parser has ItemName and wasm-wave can parse to it * wasmtime gets a new feature `wit-parser` to take the optional dep on wit-parser. (This is already in the transitive dep tree with component-model bindgen anyway.) Like with wave, provide a re-export of the crate for convenience under wasmtime::component::wit_parser. * impl ExportLookup for wit_parser::ItemName * cargo vet: imports for wasm-tools 251 family * rustfmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wit-parserto take the optional dep on wit-parser. (This is already in the transitive dep tree with component-model bindgen anyway.) Like with wave, provide a re-export of the crate for convenience under wasmtime::component::wit_parser. Unlike wave, this feature is on by default, because its already part of the transitive dep tree by default.