Restore #![no_std] support for cranelift#13401
Open
tomaka wants to merge 1 commit into
Open
Conversation
tomaka
requested review from
alexcrichton and
cfallin
and removed request for
a team
github-actions
Bot
added
the
cranelift
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Support for
#![no_std]for cranelift is currently broken, and this PR attempts to fix this.I integrated #12947 for the changes in the frontend crate, alongside with the changes to the CI that were requested in the PR review.
I've also removed the requirement on the
stdfeature ofcranelift-codegen, as otherwisecranelift-frontendautomatically pulls in thisstdfeature.I did this last change a bit blindly. A quick git blame has led me to #7369. Unfortunately I don't know enough to know to know whether removing this
stdbreaks anything, nor if it makes sense to leaveunwind.