remove callback_code::POLL and make waitable-set.poll not yield#12182
Merged
dicej merged 1 commit intobytecodealliance:mainfrom Dec 23, 2025
Merged
remove callback_code::POLL and make waitable-set.poll not yield#12182dicej merged 1 commit intobytecodealliance:mainfrom
callback_code::POLL and make waitable-set.poll not yield#12182dicej merged 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
wasmtime:api
dicej
force-pushed
the
no-more-callback-code-poll
branch
2 times, most recently
from
4c41aa8 to
38c5e0a
Compare
dicej
requested review from
alexcrichton and
pchickey
and removed request for
a team
alexcrichton
approved these changes
Dec 23, 2025
As of WebAssembly/component-model#578, there is no more `POLL` callback code, and `waitable-set.poll` should not yield. Guest toolchains can emulate the old code with a combination of `YIELD` and `waitable-set.poll`. Note that I've removed the now-redundant copy of `trap-if-block-and-sync.wast` in favor of the upstream version.
dicej
force-pushed
the
no-more-callback-code-poll
branch
from
38c5e0a to
cc0cffb
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…12182) As of WebAssembly/component-model#578, there is no more `POLL` callback code, and `waitable-set.poll` should not yield. Guest toolchains can emulate the old code with a combination of `YIELD` and `waitable-set.poll`. Note that I've removed the now-redundant copy of `trap-if-block-and-sync.wast` in favor of the upstream version.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of WebAssembly/component-model#578, there is no more
POLLcallback code, andwaitable-set.pollshould not yield. Guest toolchains can emulate the old code with a combination ofYIELDandwaitable-set.poll.Note that I've removed the now-redundant copy of
trap-if-block-and-sync.wastin favor of the upstream version.Marking this as a draft for now since it builds on #12181 and temporarily uses a fork of
wit-bindgen