Work around naked-function-plus-LTO issue #11960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to apply a local fix for bytecodealliance#11957 which works around the upstream Rust issue mentioned in that issue.
rvolosatovs
approved these changes
Nov 3, 2025
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 3, 2025
This is an attempt to apply a local fix for bytecodealliance#11957 which works around the upstream Rust issue mentioned in that issue.
alexcrichton
added a commit
that referenced
this pull request
Nov 4, 2025
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 6, 2026
This is an attempt to address bytecodealliance#12217 which applies a similar workaround found in bytecodealliance#11960 to this naked function as well. Effectively it looks like `#[unsafe(naked)]` is buggy to the point that the user of the function symbol must be `#[inline(never)]` and in the same module, otherwise it won't work correctly. Closes bytecodealliance#12217
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
This is an attempt to address #12217 which applies a similar workaround found in #11960 to this naked function as well. Effectively it looks like `#[unsafe(naked)]` is buggy to the point that the user of the function symbol must be `#[inline(never)]` and in the same module, otherwise it won't work correctly. Closes #12217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to apply a local fix for #11957 which works around the upstream Rust issue mentioned in that issue.