Skip to content

Conversation

@jder
Copy link
Contributor

@jder jder commented Aug 4, 2025

This makes two small changes to the CacheConfig/Cache system:

First, the comments referred to enabled/disabled caches, which is no longer a thing after #10665, so I've removed this. There were also some docs about panics in these cases (which are also now impossible) which I removed.

Second, CacheConfig::default()/CacheConfig::new() produced configs which would panic if you asked for their directory without first calling validate, but validate is not public API. So instead we return an Option from CacheConfig::directory() and move the panic to Cache::directory() and WorkerThread::directory() which should be impossible to trigger (since validate is called by Cache::new). We could alternatively make a ValidatedCacheConfig or something which is returned from validate and store/pass that around, but it seemed a bit overkill to me.

cc @benbrandt who was working on this recently in case I'm missing something.

@jder jder requested a review from a team as a code owner August 4, 2025 14:11
@jder jder requested review from alexcrichton and removed request for a team August 4, 2025 14:11
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Aug 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2025
@alexcrichton alexcrichton added this pull request to the merge queue Aug 4, 2025
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Aug 4, 2025
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Merged via the queue into bytecodealliance:main with commit 61a371a Aug 4, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants