-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Description
Feature
Remove the use of async_trait
in bindgen!
as per #9776 (comment). Use async fn in traits, RPITIT and trait_variant
instead.
Benefit
Removing async_trait
simplifies the generated code by bindgen!
a lot. This can also drastically improve IDE experience as IDEs have better support for async fn in traits and RPITIT. Coding experience should be much better as well, as programmers can just use async fn
when implementing autogenerated traits by bindgen
in async mode.
Implementation
Note: I don't have time to dig into details now, so this issue is primary for tracking. Probably someone can tag this as "good first issue" :)
Just search for ::async_trait
in the source code of wit-bindgen
crate:
There are not many occurrences to my surprise.

In theory, we need to generate something like:
#[trait_variant::make(HostX: Send)]
pub trait LocalHostX {
//...
}
instead of
#[async_trait]
pub trait HostX {
//...
}