Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocation of memory.grow and memory.size #199

Closed
mrowqa opened this issue Jul 18, 2019 · 3 comments
Closed

Relocation of memory.grow and memory.size #199

mrowqa opened this issue Jul 18, 2019 · 3 comments

Comments

@mrowqa
Copy link
Contributor

mrowqa commented Jul 18, 2019

As we discussed with @sunfishcode, after merging #194 there's probably no need for {Imported,}Memory32{Grow,Size} in RelocationTarget, or at least the tests pass. However, there are is an idea for having a command line setting which allows user to choose between fast startup using cache and less relocations, or better performance paying extra time for compilation and relocation. The mentioned code hasn't been deleted and it's just a tracking issue.

@kubkon
Copy link
Member

kubkon commented Jul 18, 2019

Oooh I do like the idea of having a command line argument which would allow the user to choose between a fast startup but poorer performance, and better performance but slower startup. So a definite +1 for that from me :-)

@pepyakin
Copy link
Contributor

I wonder if this requires dedicated flags or it could be generalized as, bikeshedingly, --fast-start/--more-performace.

@alexcrichton
Copy link
Member

Thes relocations ended up getting removed in #949 and we can always make a new issue if the current relocation strategy is too slow for some use cases!

mooori pushed a commit to mooori/wasmtime that referenced this issue Feb 14, 2024
dhil added a commit to dhil/wasmtime that referenced this issue Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants