Skip to content

Commit

Permalink
Run the nightly CI job when pulley files are touched in a PR (#9391)
Browse files Browse the repository at this point in the history
* Run the nightly CI job when `pulley` files are touched in a PR

After #9251, we will check that
Pulley builds with rustc's experimental tail calls feature enabled in the
nightly CI job. So if we touch any pulley source files in a PR, we should also
run that job in the PR's CI.

* Also run MIRI tests if `pulley` files are changed

* review feedback

* grep for miri in changed files, not commit messages
  • Loading branch information
fitzgen authored Oct 7, 2024
1 parent b0e0559 commit 2772d2b
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ jobs:
build-matrix: ${{ steps.calculate.outputs.build-matrix }}
test-capi: ${{ steps.calculate.outputs.test-capi }}
test-nightly: ${{ steps.calculate.outputs.test-nightly }}
test-miri: ${{ steps.calculate.outputs.test-miri }}
audit: ${{ steps.calculate.outputs.audit }}
preview1-adapter: ${{ steps.calculate.outputs.preview1-adapter }}
run-dwarf: ${{ steps.calculate.outputs.run-dwarf }}
Expand Down Expand Up @@ -246,6 +247,10 @@ jobs:
if grep -q debug names.log; then
echo run-dwarf=true >> $GITHUB_OUTPUT
fi
if grep -q pulley names.log; then
echo test-nightly=true >> $GITHUB_OUTPUT
echo test-miri=true >> $GITHUB_OUTPUT
fi
fi
matrix="$(node ./ci/build-test-matrix.js ./commits.log ./names.log $run_full)"
echo "test-matrix={\"include\":$(echo $matrix)}" >> $GITHUB_OUTPUT
Expand All @@ -258,6 +263,7 @@ jobs:
echo run-full=true >> $GITHUB_OUTPUT
echo test-capi=true >> $GITHUB_OUTPUT
echo test-nightly=true >> $GITHUB_OUTPUT
echo test-miri=true >> $GITHUB_OUTPUT
echo audit=true >> $GITHUB_OUTPUT
echo preview1-adapter=true >> $GITHUB_OUTPUT
echo run-dwarf=true >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -1034,7 +1040,7 @@ jobs:
- "wasmtime-environ"
- "pulley-interpreter --all-features"
needs: determine
if: needs.determine.outputs.run-full && github.repository == 'bytecodealliance/wasmtime'
if: needs.determine.outputs.test-miri && github.repository == 'bytecodealliance/wasmtime'
name: Miri
runs-on: ubuntu-latest
env:
Expand Down

0 comments on commit 2772d2b

Please sign in to comment.