Skip to content

Conversation

@saulecabrera
Copy link
Member

This commit updates rb-sys to the latest version. I'm hoping that this will fix the failures that are currently in main

This commit updates rb-sys to the latest version. I'm hoping that this will fix the failures that are currently in main
@saulecabrera
Copy link
Member Author

@ianks I'm mostly flying blind here, but do you think that this change will help resolve the failures in main: https://github.com/bytecodealliance/wasmtime-rb/actions/runs/8816496220/job/24246997925?

@saulecabrera saulecabrera requested a review from ianks April 25, 2024 14:00
@saulecabrera
Copy link
Member Author

Ah, I'll confirm by running the action with this branch.

@ianks
Copy link
Collaborator

ianks commented Apr 25, 2024

yes 0.9.97 should fix that issue, as well add support for aarch64-linux-musl

3.0 is no longer considered stable ruby version and according to https://github.com/rake-compiler/rake-compiler-dock?tab=readme-ov-file#windows, x64-mingw32 should be used for 3.0 and below
@saulecabrera
Copy link
Member Author

saulecabrera commented Apr 25, 2024

Thanks, yeah that fixed it, there's also an issue with x64-mingw32 I believe we need to exclude it given that 3.0 is no longer considered stable? See 68fb3d5

@saulecabrera
Copy link
Member Author

Yeah, excluding x64-mingw32 fixed the issue https://github.com/bytecodealliance/wasmtime-rb/actions/runs/8834566920

@saulecabrera saulecabrera merged commit e7923c5 into main May 7, 2024
@saulecabrera saulecabrera deleted the update-rb-sys branch May 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants