-
Notifications
You must be signed in to change notification settings - Fork 24
add string buffer for stdout and stderr #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add string buffer for stdout and stderr #316
Conversation
saulecabrera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! I left a couple of suggestions and comments before landing this.
saulecabrera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this, this looks good to me. I'm not sure what's going on with the 3.0 runners though, I don't think it's related to this PR. I'll take a look.
|
Note on the runners: 3.0 is no longer part of the From: https://github.com/oxidize-rb/actions/blob/main/fetch-ci-data/evaluate.rb#L54 ["3.1","3.2","3.3","head"] |
This PR adds support for using a string with a byte limit as the stdout and stderr for
WasiCtxandWasiCtxBuilder.Usage: