Add the Store type back to the API. #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
approved these changes
Jun 29, 2020
This is a breaking API change. The `Host` class was split back into a `Store` type, where loading of modules will occur. This allows for loading modules into a single store and defining one or more hosts that instantiate the modules without having to load the modules again. Fixes #9.
Co-authored-by: Yury Delendik <ydelendik@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change.
The
Hostclass was split back into aStoretype, where loading of moduleswill occur.
This allows for loading modules into a single store and defining one or more
hosts that instantiate the modules without having to load the modules again.
Fixes #9.