Add .NET Standard 2.1 (netstandard2.1) as target framework
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the highest target fromwork supported by the current Unity version (2021.3), and the project builds fine using that version, so there would actually be no need to target .NET 6.0.
peterhuene
approved these changes
Oct 17, 2022
Member
|
@kpreisser thanks for this. Sorry I've been on vacation the last two weeks, so I'll get to your other PRs soon (trying to play the "just back from vacation" catch-up game). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As noted by @martindevans in #160 (comment), Unity up to version 2022.2 currently supports .NET Standard 2.1 (
netstandard2.1, released with .NET Core 3.1) as highest .NET target framework. See .NET profile support in the Unity documentation.While the
net6.0library apparently could also be used in Unity, it would break as soon as any feature/type introduced in a newer .NET version was used. Therefore, I think it would be a good idea to also build for .NET Standard 2.1 for the time being in order to support Unity users. Note thatWasmtimealready builds successfully fornetstandard2.1without any code change (at least when using C# 10).(The
net6.0target can be kept to benefit from the newest analyzers and NRT annotations.)What do you think?
Thanks!