Fix issues in Function.FromCallback() and Linker.DefineFunction()
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of invoking callback.Method (that may have a different parameter count than the callback), invoke the callback's Invoke() method. - Handle a ITuple return value only when GetFunctionType determined that the function returns a tuple, to correctly return a boxed ValueTuple as externref. - Support nested levels of ValueTuples, so that it's possible e.g. to return a ValueTulple<..., ValueTuple<..., ValueTuple<...>>> (15 values). Fixes bytecodealliance#158 Fixes bytecodealliance#159
kpreisser
changed the title
Function.FromCallback() and Linker.DefineFunction()
peterhuene
approved these changes
Oct 20, 2022
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Excellent, thanks for these fixes!
kpreisser
added a commit
to kpreisser/wasmtime-dotnet
that referenced
this pull request
Oct 21, 2022
This is a follow-up to PR bytecodealliance#161.
peterhuene
pushed a commit
that referenced
this pull request
Oct 21, 2022
) This is a follow-up to PR #161.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a PR to fix the following issues when using
Function.FromCallback()andLinker.DefineFunction():callback.Method(that may have a different parameter count than the callback), invoke the callback'sInvokemethod.ITuplereturn value only whenGetFunctionType()determined that the function returns a tuple, to correctly return a boxedValueTupleasexternref.ValueTuples, so that it's possible e.g. to return aValueTulple<..., ValueTuple<..., ValueTuple<...>>>(15 values).Fixes #158
Fixes #159
Thank you!