Force using sync resource-drop during fuzzing#2072
Closed
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Closed
Force using sync resource-drop during fuzzing#2072alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
sync resource-drop during fuzzing#2072alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This commit fixes fuzzer fallout from bytecodealliance#2065 and related PRs where previously async destructor imports were being generated but were actually bound with synchronous destructor imports. Now `wit-component` is generating an error on async resource destructors so this fixes the generator to avoid generating such imports for now while there's not support for lowering them.
Member
Author
|
This is a pretty small change and one more was needed for #2073 so I'm going to close this in favor of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes fuzzer fallout from #2065 and related PRs where previously async destructor imports were being generated but were actually bound with synchronous destructor imports. Now
wit-componentis generating an error on async resource destructors so this fixes the generator to avoid generating such imports for now while there's not support for lowering them.