Remove v1 encoding support for WIT documents/worlds #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes support for the "v1" encoding of WIT packages into WebAssembly. This was originally migrated to v2 in bytecodealliance#1252 and v2 was enabled by default in bytecodealliance#1274. This finishes the transition by removing support for creating the old encoding.
dicej
approved these changes
Sep 12, 2024
| let mut interfaces = IndexSet::new(); | ||
| for (_, id) in self.resolve.packages[self.package].interfaces.iter() { | ||
| self.add_live_interfaces(&mut interfaces, *id); | ||
| for (name, &id) in self.resolve.packages[self.package].interfaces.iter() { |
There was a problem hiding this comment.
Should the comment above this code be reworded given these changes? It seems odd that the exact same comment is duplicated below in encode_interface; it seems like a better fit there than here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for the "v1" encoding of WIT packages into WebAssembly. This was originally migrated to v2 in #1252 and v2 was enabled by default in #1274. This finishes the transition by removing support for creating the old encoding.