wit-component: Re-export _start while shared-everything link#1339
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Dec 18, 2023
Merged
Conversation
This is a bit of a hack to componentize a WASI preview1 command module with shared-everything linking. The `_start` function was not being exported, so `wasm-tools component link` was failing to link modules with `wasi_snapshot_preview1.command.wasm` adapter.
dicej
approved these changes
Dec 18, 2023
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Makes sense to me. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack to componentize a WASI preview1 command module with shared-everything linking. The
_startfunction was not being exported, sowasm-tools component linkwas failing to link modules withwasi_snapshot_preview1.command.wasmadapter.