ESP IDF fixes #927
Merged
ESP IDF fixes #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an incorrect type usage.
The stack base address is only available when tracing is on. Thus add an sdkconfig that has tracing on.
wallento
force-pushed
the
esp-idf-fixes
branch
from
bf673e5 to
2016318
Compare
|
Amended after clang-format patch |
wenyongh
reviewed
Dec 31, 2021
wallento
force-pushed
the
esp-idf-fixes
branch
from
2016318 to
2a97037
Compare
|
Amended after memory allocation fix |
|
Put into draft mode, further fixes necessary (stack overflow on esp32c3 now too) |
AoT requires mmap() memory to have EXEC protection. Call the proper capability-based malloc in esp-idf to allocate memory in that case.
The memory protection seems to interfere with capability-based malloc. Turn it off for now and reiterate later.
wallento
force-pushed
the
esp-idf-fixes
branch
2 times, most recently
from
6aeccfa to
2beb48d
Compare
Generalize the build for different targets, esp32 and esp32c3 for now.
Increase the main pthread stack size to avoid stack overflow.
wallento
force-pushed
the
esp-idf-fixes
branch
from
2beb48d to
f6ccbf0
Compare
|
Okay, looks better now, both targets run fine |
|
Added build scripts to include with esp-idf to use wamr as an ESP-IDF component! Not sure if that is the right place where I put it.. |
wallento
force-pushed
the
esp-idf-fixes
branch
from
96875cb to
6897faf
Compare
This is the build-script to use wasm-micro-runtime as an ESP-IDF component in ESP-IDF projects. With this file it is only necessary to add the component dir and then use the component in an ESP-IDF project.
wallento
force-pushed
the
esp-idf-fixes
branch
from
6897faf to
0cd9390
Compare
Reorganize the product-mini demo of ESP-IDF to actually use the ESP-IDF component infrastructure. This also serves as example then, so remove that duplicate code. Fine-tuning to run both the interpreter and the AoT, and use esp-idf logging.
The xtensa compiler occasionally emits a sequence of byte-access loads and stores for memcpy. This crashes the chip because its illegal to do that on IRAM. Instead access the word. Seems to not occur for the 8-byte variant.
When malloc was not successful, also don't start writing to the fields relative to it and instead return.
wallento
force-pushed
the
esp-idf-fixes
branch
from
6db3d93 to
4b255d4
Compare
1c3t3a
reviewed
Jan 3, 2022
wenyongh
reviewed
Jan 4, 2022
Fix the naming of the feature check definitions to the standard naming.
Properly handle NULL argument and return of realloc.
|
Amended with review feedback, thanks! |
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Various fixes and beautifications coordinated with @1c3t3a, fixes 2 of the 3 all remaining issues from bytecodealliance#892: - enable to os_mmap executable memory - fix os_malloc/os_realloc/os_free issues - implement os_thread_get_stack_boundary - add build scripts to include with esp-idf to use wamr as an ESP-IDF component - update sample and document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes and beautifications coordinated with @1c3t3a
Fixes
2 of the 3all remaining issues from #892