Add new E_TYPE_XIP to indicate XIP mode #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
9595435 to
ead9224
Compare
no1wudi
changed the title
wenyongh
reviewed
Dec 7, 2021
wenyongh
reviewed
Dec 7, 2021
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
9666456 to
2ad4e07
Compare
wenyongh
reviewed
Dec 7, 2021
wenyongh
reviewed
Dec 8, 2021
There was a problem hiding this comment.
Hi, after testing , we found several issues, could you please help modify:
-
aot_loader.c, about Line 1470:
Change
if ((module->code_size > 0) && (module->native_symbol_count == 0)) {
to
if ((module->code_size > 0) && !module->is_indirect_mode) { -
aot_loader.c, about Line 480:
remove
module->native_symbol_count = cnt; -
aot_runtime.h
remove native_symbol_count field in struct AOTModule
To test spec cases for AOT with XIP mode, you can:
cd tests/wamr-test-suites
./test_wamr.sh -s spec -t aot -X
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Emit e_type = E_TYPE_XIP in target info section to indicate that it is an XIP file, and replace related checks in aot loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAMRC will emit E_TYPE_XIP while enable indirect mode, this will break the capability.