Don't throw exception while malloc failed #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In acquire_wait_info the key of hasn_map_find can be NULL thus there are many sesenless error log
wenyongh
reviewed
Dec 2, 2021
core/shared/utils/bh_hashmap.c
Outdated
|
|
||
| if (!map || !key) { | ||
| LOG_ERROR("HashMap find elem failed: map or key is NULL.\n"); | ||
| if (!map) { |
There was a problem hiding this comment.
My understanding is that we should modify acquire_wait_info in wasm_shared_memory.c but not here, e.g. change to:
static AtomicWaitInfo *
acquire_wait_info(void *address, bool create)
{
AtomicWaitInfo *wait_info = NULL;
bh_list_status ret;
if (address) => add check here
wait_info = (AtomicWaitInfo *)bh_hash_map_find(wait_map, address);
if (!create)
return wait_info;@xujuntwt95329, what's you opinion? Qi found that "In acquire_wait_info the key of hasn_map_find can be NULL thus there are many senseless error logs".
There was a problem hiding this comment.
Yes, I agree with @wenyongh, the caller should avoid passing NULL pointer to bh_hash_map_find
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Don't throw exception when module_malloc memory failed: - Exception will terminate the wasm app, it's not necessary since app can check the result of dynamic allocation and do some cleanup or fallback operation on failure instead of 'crash' directly. - In acquire_wait_info, call hasn_map_find only when the address isn't NULL, or there are many senseless error logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many sesenless error log