Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AoT on Win32 & Win64 #540

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Conversation

Paril
Copy link
Contributor

@Paril Paril commented Feb 23, 2021

This fixes #531 and implements the missing functions that were patched out in PR #322. Allows AoT to work on Windows.

@Paril Paril changed the title Fix AoT on Win32 Fix AoT on Win32 & Win64 Feb 23, 2021
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

core/iwasm/aot/aot_runtime.c Outdated Show resolved Hide resolved
core/iwasm/aot/arch/aot_reloc_x86_32.c Outdated Show resolved Hide resolved
core/iwasm/aot/arch/aot_reloc_x86_64.c Outdated Show resolved Hide resolved
Removed (u)div stuff from x86_64 as it seemed to be unused (I checked an AoT compilation with target x86_64 and it didn't seem to emit these two symbols where it does with i386, so I'm guessing these don't need to be emulated on x64?)
@wenyongh wenyongh merged commit 79afa49 into bytecodealliance:main Feb 23, 2021
wenyongh referenced this pull request in wenyongh/wasm-micro-runtime Feb 23, 2021
 Fix windows aot loader fail to resolve symbol issue (#540)
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AoT loading failure(s)
3 participants