Skip to content

Conversation

@yamt
Copy link
Collaborator

@yamt yamt commented Sep 2, 2025

this commit includes:

@yamt
Copy link
Collaborator Author

yamt commented Sep 2, 2025

can anyone familiar with windows test this? i haven't tested at all.

i guess we should improve the CI coverage for windows.

this commit includes:

* update windows for
  * WASM_MEM_ALLOC_WITH_USAGE
  * InstantiationArgs2
  * --jit-codecache-size
  * --disable-bounds-checks
  * wasm_proposal_print_status

* fix WASM_ENABLE_SHARED_HEAP for windows
  (bytecodealliance#4592)

* cosmetic changes to reduce the diff
@yamt
Copy link
Collaborator Author

yamt commented Sep 2, 2025

the CI failure looks like #4316
i'm going to restart it.

https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/17389528884/job/49361128052?pr=4593


 3/10 Test  #3: Test_empty_imports ...............   Passed    0.03 sec
      Start  4: Test_global
 4/10 Test  #4: Test_global ......................   Passed    0.04 sec
      Start  5: Test_hello
 5/10 Test  #5: Test_hello .......................   Passed    0.06 sec
      Start  6: Test_hostref
 6/10 Test  #6: Test_hostref .....................***Timeout 1500.03 sec
Initializing...
Loading binary...
Compiling module...
[00:04:20:642 - 7FF848A4CA00]: failed to link function (, f): WASM module instantiate failed: unknown import
Creating callback...
Instantiating module...
Extracting exports...
Creating host references...
Accessing global...
call_v_r... okay
call_r_v... okay
call_v_r... okay
call_r_v... okay
call_v_r... okay
call_r_v... okay
call_v_r... okay
Accessing table...
call_i_r... okay
call_i_r... okay
call_ir_v... okay
call_ir_v... okay
call_i_r... okay
call_i_r... okay
call_ir_v... okay
call_i_r... okay
call_i_r... okay
Accessing function...
call_r_r... Calling back...
> > 0x0
okay
call_r_r... Calling back...
> > 0x1
okay

      Start  7: Test_memory
 7/10 Test  #7: Test_memory ......................   Passed    0.11 sec
      Start  8: Test_reflect
 8/10 Test  #8: Test_reflect .....................   Passed    0.09 sec
      Start  9: Test_table
 9/10 Test  #9: Test_table .......................   Passed    0.11 sec
      Start 10: Test_trap
10/10 Test #10: Test_trap ........................   Passed    0.05 sec

90% tests passed, 1 tests failed out of 10

Total Test time (real) = 1500.62 sec

The following tests FAILED:
	  6 - Test_hostref (Timeout)
Errors while running CTest
Error: Process completed with exit code 8.

@lum1n0us lum1n0us added the enhancement Check if this issue/PR enhances a feature; scripts will use this info. label Sep 5, 2025
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that fast jit (and therefore multi-tier jit) doesn't work correctly on Windows. Maybe we can add more in the future.

@yamt
Copy link
Collaborator Author

yamt commented Sep 12, 2025

I remember that fast jit (and therefore multi-tier jit) doesn't work correctly on Windows. Maybe we can add more in the future.

is there a github issue for it?

@TianlongLiang
Copy link
Collaborator

No, just me tried it 10 months ago. I remembered it was caused by something in some asmjit library. To be honest, I don't think WAMR has many Windows users, and I always think it's good enough to only start paying attention to test/fix when someone actually uses a certain feature on Windows.

@lum1n0us lum1n0us merged commit 92b065a into bytecodealliance:main Sep 14, 2025
527 of 528 checks passed
kr-t pushed a commit to project-ocre/wasm-micro-runtime that referenced this pull request Nov 13, 2025
this commit includes:

* update windows for
  * WASM_MEM_ALLOC_WITH_USAGE
  * InstantiationArgs2
  * --jit-codecache-size
  * --disable-bounds-checks
  * wasm_proposal_print_status

* fix WASM_ENABLE_SHARED_HEAP for windows
  (bytecodealliance#4592)

* cosmetic changes to reduce the diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Check if this issue/PR enhances a feature; scripts will use this info.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants