-
Notifications
You must be signed in to change notification settings - Fork 739
sync iwasm between windows and posix a bit #4593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
can anyone familiar with windows test this? i haven't tested at all. i guess we should improve the CI coverage for windows. |
this commit includes: * update windows for * WASM_MEM_ALLOC_WITH_USAGE * InstantiationArgs2 * --jit-codecache-size * --disable-bounds-checks * wasm_proposal_print_status * fix WASM_ENABLE_SHARED_HEAP for windows (bytecodealliance#4592) * cosmetic changes to reduce the diff
|
the CI failure looks like #4316 |
TianlongLiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that fast jit (and therefore multi-tier jit) doesn't work correctly on Windows. Maybe we can add more in the future.
is there a github issue for it? |
|
No, just me tried it 10 months ago. I remembered it was caused by something in some asmjit library. To be honest, I don't think WAMR has many Windows users, and I always think it's good enough to only start paying attention to test/fix when someone actually uses a certain feature on Windows. |
this commit includes: * update windows for * WASM_MEM_ALLOC_WITH_USAGE * InstantiationArgs2 * --jit-codecache-size * --disable-bounds-checks * wasm_proposal_print_status * fix WASM_ENABLE_SHARED_HEAP for windows (bytecodealliance#4592) * cosmetic changes to reduce the diff
this commit includes:
update windows for
fix WASM_ENABLE_SHARED_HEAP for windows (WASM_ENABLE_SHARED_HEAP for windows cli seems broken #4592)
cosmetic changes to reduce the diff