Unit test and sample update for shared heap enhancement #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
reviewed
Feb 11, 2025
lum1n0us
reviewed
Feb 25, 2025
lum1n0us
reviewed
Feb 25, 2025
lum1n0us
reviewed
Feb 25, 2025
lum1n0us
reviewed
Feb 25, 2025
lum1n0us
reviewed
Feb 25, 2025
Co-authored-by: liang.he <liang.he@intel.com>
lum1n0us
approved these changes
Feb 27, 2025
|
|
||
| static bool | ||
| load_wasm(char *wasm_file_tested, unsigned int app_heap_size, | ||
| ret_env &ret_module_env) | ||
| { | ||
| std::string wasm_mem_page = wasm_file_tested; | ||
| const char *wasm_file = strdup(wasm_mem_page.c_str()); |
There was a problem hiding this comment.
It appears that the sole purpose of wasm_mem_page is to generate wasm_file. So, why not utilize wasm_file_tested directly?
TianlongLiang
requested review from
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.