Skip to content

Use alternate method to check getrandom support #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Use alternate method to check getrandom support #3848

merged 1 commit into from
Oct 10, 2024

Conversation

@bnason-nf
Copy link
Contributor

@bnason-nf bnason-nf commented Oct 9, 2024 •
edited
Loading

I was still getting compile failures on an older Linux system (3.10), so hopefully this is a more direct way to check for getrandom support.

lum1n0us
lum1n0us approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 2b5e2d9 into bytecodealliance:main Oct 10, 2024
383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyongh wenyongh wenyongh approved these changes

@lum1n0us lum1n0us lum1n0us approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bnason-nf @wenyongh @lum1n0us