Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm loader: Fix several issues in GC and exception handling #3586

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

wenyongh
Copy link
Contributor

@wenyongh wenyongh commented Jul 2, 2024

Fix several issues of GC and exception handling in wasm loader:

  • Should restore param_reftype_maps/param_reftype_map_count/param_count
    in the handling of opcode throw
  • Should set wasm_ref_type when pushing param types of tag type and block type
    if the type is a multi-byte type
  • Should set init_values.data as NULL for opcode struct.new_default in load_init_expr

This PR fixes the issues reported in #3411.

@wenyongh wenyongh changed the title wasm loader: Fix several issues of GC and exception handling wasm loader: Fix several issues in GC and exception handling Jul 4, 2024
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 0feae05 into bytecodealliance:main Jul 5, 2024
378 checks passed
@wenyongh wenyongh deleted the fix_loader_issues branch July 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants