Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make wasi-nn backends as separated shared libraries #3509

Merged

Conversation

lum1n0us
Copy link
Collaborator

@lum1n0us lum1n0us commented Jun 6, 2024

No description provided.

@lum1n0us lum1n0us changed the title Feat/wasi nn backend libiwasm make wasi-nn backends as separated shared libraries Jun 6, 2024
@lum1n0us lum1n0us force-pushed the feat/wasi_nn_backend_libiwasm branch 2 times, most recently from f353696 to 747982c Compare June 11, 2024 05:44
- All files under *core/iwasm/libraries/wasi-nn* are in shared libraries.
- *wasi-nn.c* is shared between backends.
- Every backend has a separated shared library.
- If enabling wasi-nn feature, iwasm will depends on shared libraries
  instead of static libraries.
@lum1n0us lum1n0us force-pushed the feat/wasi_nn_backend_libiwasm branch from 747982c to 208ffd5 Compare June 11, 2024 06:01
@lum1n0us lum1n0us marked this pull request as ready for review June 12, 2024 06:07
@lum1n0us
Copy link
Collaborator Author

@tonibofarull please make a review.

BTW, as mentioned in #3493, we're working on more backends.

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit f844b33 into bytecodealliance:main Jun 14, 2024
379 checks passed
@lum1n0us lum1n0us deleted the feat/wasi_nn_backend_libiwasm branch November 20, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants