Move spec test to the last commit of Apr.3 #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
commented
Apr 9, 2024
lum1n0us
commented
Apr 9, 2024
lum1n0us
force-pushed
the
fix/latest_spec_test_commit
branch
from
f44e6e5 to
b8a5c1f
Compare
lum1n0us
force-pushed
the
fix/latest_spec_test_commit
branch
from
540350b to
0cb2e72
Compare
lum1n0us
force-pushed
the
fix/latest_spec_test_commit
branch
7 times, most recently
from
7e34e4e to
f7adb29
Compare
wenyongh
reviewed
May 9, 2024
| # multi-module only enable in interp mode and aot mode | ||
| if [[ ${ENABLE_MULTI_MODULE} -eq 1 ]]; then | ||
| if [[ "${RUNNING_MODE}" != "classic-interp" \ | ||
| && "${RUNNING_MODE}" != "fast-interp" ]]; then |
There was a problem hiding this comment.
Should also add aot, && "${RUNNING_MODE}" != "aot"
There was a problem hiding this comment.
aot + multi-modules will fail the linking test case. Tend to fix it in another PR.
lum1n0us
force-pushed
the
fix/latest_spec_test_commit
branch
4 times, most recently
from
90476ef to
1290c0d
Compare
- update spec test to commit bc76fd79cfe61033d7f4ad4a7e8fc4f996dc5ba8 on Apr. 3 - upddate wabt binary to 1.0.34 to support newer spec cases - Add comparision between table declared elem type and elem segment value type - Add a function to decide whether to execute test cases in a running mode - keep using interpreter in GC spec because wat2wasm in wabt can't compile if.wast w/o errors - re-factoring threads spec test case processing - since wabt 1.0.34 release isn't compatible with ubuntu 20.04, compile from source code
lum1n0us
force-pushed
the
fix/latest_spec_test_commit
branch
from
1290c0d to
494d7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.