Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module name into aot's perf map #3265

Merged

Conversation

lum1n0us
Copy link
Collaborator

Still missing the python script to filter every wasm's profiling data out

@lum1n0us lum1n0us force-pushed the feat/module_name_in_perf_map branch 6 times, most recently from 42c1648 to c2b5c1c Compare April 1, 2024 02:58
@lum1n0us lum1n0us marked this pull request as ready for review April 2, 2024 02:07
@lum1n0us lum1n0us force-pushed the feat/module_name_in_perf_map branch 2 times, most recently from 4de0062 to 604b709 Compare April 3, 2024 04:37
core/iwasm/aot/aot_perf_map.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_perf_map.h Outdated Show resolved Hide resolved
@lum1n0us lum1n0us force-pushed the feat/module_name_in_perf_map branch 2 times, most recently from 577e1cc to f5b6170 Compare April 7, 2024 01:16
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- a new API, wasm_runtime_load_ex().
- in perf.map, function names include user specified module name
- enhance the script to help flamegraph generations
@lum1n0us lum1n0us force-pushed the feat/module_name_in_perf_map branch from f5b6170 to bfc9a4f Compare April 7, 2024 05:59
@wenyongh wenyongh merged commit 4ef724b into bytecodealliance:main Apr 7, 2024
386 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 1, 2024
…alliance#3265)

- Add new API wasm_runtime_load_ex() in wasm_export.h
  and wasm_module_new_ex in wasm_c_api.h
- Put aot_create_perf_map() into a separated file aot_perf_map.c
- In perf.map, function names include user specified module name
- Enhance the script to help flamegraph generations
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 2, 2024
…alliance#3265)

- Add new API wasm_runtime_load_ex() in wasm_export.h
  and wasm_module_new_ex in wasm_c_api.h
- Put aot_create_perf_map() into a separated file aot_perf_map.c
- In perf.map, function names include user specified module name
- Enhance the script to help flamegraph generations

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…alliance#3265)

- Add new API wasm_runtime_load_ex() in wasm_export.h
  and wasm_module_new_ex in wasm_c_api.h
- Put aot_create_perf_map() into a separated file aot_perf_map.c
- In perf.map, function names include user specified module name
- Enhance the script to help flamegraph generations
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…alliance#3265)

- Add new API wasm_runtime_load_ex() in wasm_export.h
  and wasm_module_new_ex in wasm_c_api.h
- Put aot_create_perf_map() into a separated file aot_perf_map.c
- In perf.map, function names include user specified module name
- Enhance the script to help flamegraph generations

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…alliance#3265)

- Add new API wasm_runtime_load_ex() in wasm_export.h
  and wasm_module_new_ex in wasm_c_api.h
- Put aot_create_perf_map() into a separated file aot_perf_map.c
- In perf.map, function names include user specified module name
- Enhance the script to help flamegraph generations

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
@lum1n0us lum1n0us deleted the feat/module_name_in_perf_map branch May 31, 2024 03:18
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request Jun 7, 2024
…alliance#3265)

- Add new API wasm_runtime_load_ex() in wasm_export.h
  and wasm_module_new_ex in wasm_c_api.h
- Put aot_create_perf_map() into a separated file aot_perf_map.c
- In perf.map, function names include user specified module name
- Enhance the script to help flamegraph generations

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants